On Thu, Jun 03, 2021 at 07:06:09PM +0100, Jonathan Cameron wrote:
> From: Arnd Bergmann <arnd@xxxxxxxx>
>
> clang complains about multiple instances of printing an integer
> using the %hhx format string:
>
> drivers/iio/light/si1133.c:982:4: error: format specifies type 'unsigned char' but the argument has type 'unsigned int' [-Werror,-Wformat]
> part_id, rev_id, mfr_id);
> ^~~~~~~
>
> Print them as a normal integer instead, leaving the "#02"
> length modifier.
>
> Use the 0x02x form as the length specifier when used with # includes
> the 0x prefix and is very unlikely to be what was intended by the author.
>
> Fixes: e01e7eaf37d8 ("iio: light: introduce si1133")
> Signed-off-by: Arnd Bergmann <arnd@xxxxxxxx>
> Cc: Nathan Chancellor <nathan@xxxxxxxxxx>
> Signed-off-by: Jonathan Cameron <Jonathan.Cameron@xxxxxxxxxx>
Reviewed-by: Nathan Chancellor <nathan@xxxxxxxxxx>
> ---
> drivers/iio/light/si1133.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/iio/light/si1133.c b/drivers/iio/light/si1133.c
> index c280b4195003..0accea7090ee 100644
> --- a/drivers/iio/light/si1133.c
> +++ b/drivers/iio/light/si1133.c
> @@ -978,11 +978,11 @@ static int si1133_validate_ids(struct iio_dev *iio_dev)
> return err;
>
> dev_info(&iio_dev->dev,
> - "Device ID part %#02hhx rev %#02hhx mfr %#02hhx\n",
> + "Device ID part 0x%02x rev 0x%02x mfr 0x%02x\n",
> part_id, rev_id, mfr_id);
> if (part_id != SI1133_PART_ID) {
> dev_err(&iio_dev->dev,
> - "Part ID mismatch got %#02hhx, expected %#02x\n",
> + "Part ID mismatch got 0x%02x, expected 0x%02x\n",
> part_id, SI1133_PART_ID);
> return -ENODEV;
> }
> --
> 2.31.1
