On Thu, 3 Jun 2021 21:55:51 +0200 Wolfram Sang <wsa@xxxxxxxxxx> wrote: > On Thu, Jun 03, 2021 at 05:58:35PM +0100, Jonathan Cameron wrote: > > From: Jonathan Cameron <Jonathan.Cameron@xxxxxxxxxx> > > > > If I2C is not compiled, there is no way we should see a call to > > i2c_verify_client() on a device that is an i2c client. As such, > > provide a stub to return NULL to resolve an associated build failure. > > > > The build is failing with this link error > > ld: fxls8962af-core.o: in function `fxls8962af_fifo_transfer': > > fxls8962af-core.c: undefined reference to `i2c_verify_client' > > > > Reported-by: Tom Rix <trix@xxxxxxxxxx> > > Signed-off-by: Jonathan Cameron <Jonathan.Cameron@xxxxxxxxxx> > > Fixes: 68068fad0e1c ("iio: accel: fxls8962af: fix errata bug E3 - I2C burst reads") > > Reviewed-by: Sean Nyekjaer <sean@xxxxxxxxxx> > > Cc: Wolfram Sang <wsa@xxxxxxxxxx> > > Thanks for doing this! > > Acked-by: Wolfram Sang <wsa@xxxxxxxxxx> > immutable branch at: ib-iio-i2c-5.13rc1 https://git.kernel.org/pub/scm/linux/kernel/git/jic23/iio.git I let this sit in next (via a merge with IIO togreg branch) for a day to shake out any ways in which I messed it up. As it turns out, that was a good plan given the fixes tag had gone stale. Now fixed that and will be sending a pull request to Greg KH including the update IIO merge shortly (which is in linux-next today). Thanks, Jonathan