On Wed, Jun 02, 2021 at 02:41:29PM +0300, Jarkko Nikula wrote: > Hi > > On 6/2/21 7:03 AM, William Breathitt Gray wrote: > > On Thu, May 27, 2021 at 04:58:38PM +0300, Jarkko Nikula wrote: > >> Documentation/ABI/testing/sysfs-bus-counter | 9 + > >> drivers/counter/Kconfig | 10 + > >> drivers/counter/Makefile | 1 + > >> drivers/counter/intel-qep.c | 546 ++++++++++++++++++++ > >> 4 files changed, 566 insertions(+) > >> create mode 100644 drivers/counter/intel-qep.c > > > > Hi Jarkko, > > > > I noticed the intel-qep.c file is missing an entry in the MAINTAINERS > > file. Would you be able to resubmit this patch with a proper entry added > > to MAINTAINERS so that users have the relevant contact info to reach the > > maintainers of this driver? You can keep my Signed-off tag on as well so > > that we know the code has already been reviewed. > > > Ah, added now. I sent the update and didn't dare to add your signature > due the sidenote below :-) > > Sidenote, to my understanding Signed-off-by requires patch went through > that person and Acked-by is used when maintainer accepts the patch but > another person commits it with his/her Signed-off-by. > > Jarkko Is that so? I'm not really sure myself of the particular nuances -- I wonder if there's an explanation somewhere in the Documentation files, or if someone else can explain it more in-depth. Regardless you've made all the changes I've requested so here's my Ack for your troubles. :-) Acked-by: William Breathitt Gray <vilhelm.gray@xxxxxxxxx>
Attachment:
signature.asc
Description: PGP signature
