On Thu, May 6, 2021 at 6:43 AM Guenter Roeck <linux@xxxxxxxxxxxx> wrote:
>
> With CONFIG_ACPI=n and -Werror, 0-day reports:
>
> drivers/iio/chemical/bme680_i2c.c:46:36: error:
> 'bme680_acpi_match' defined but not used
>
> Apparently BME0680 is not a valid ACPI ID. Remove it and with it
> ACPI support from the bme680_i2c driver.
Reviewed-by: Andy Shevchenko <andy.shevchenko@xxxxxxxxx>
with the SPI part amended in the same way.
Thanks!
> Reported-by: kernel test robot <lkp@xxxxxxxxx>
> Cc: Andy Shevchenko <andy.shevchenko@xxxxxxxxx>
> Cc: Hans de Goede <hdegoede@xxxxxxxxxx>
> Signed-off-by: Guenter Roeck <linux@xxxxxxxxxxxx>
> ---
> v2: Instead of making bme680_acpi_match conditional,
> remove ACPI support entirely since the ACPI ID is
> not valid.
>
> drivers/iio/chemical/bme680_i2c.c | 8 --------
> 1 file changed, 8 deletions(-)
>
> diff --git a/drivers/iio/chemical/bme680_i2c.c b/drivers/iio/chemical/bme680_i2c.c
> index 29c0dfa4702b..74cf89c82c0a 100644
> --- a/drivers/iio/chemical/bme680_i2c.c
> +++ b/drivers/iio/chemical/bme680_i2c.c
> @@ -11,7 +11,6 @@
> * Note: SDO pin cannot be left floating otherwise I2C address
> * will be undefined.
> */
> -#include <linux/acpi.h>
> #include <linux/i2c.h>
> #include <linux/module.h>
> #include <linux/regmap.h>
> @@ -42,12 +41,6 @@ static const struct i2c_device_id bme680_i2c_id[] = {
> };
> MODULE_DEVICE_TABLE(i2c, bme680_i2c_id);
>
> -static const struct acpi_device_id bme680_acpi_match[] = {
> - {"BME0680", 0},
> - {},
> -};
> -MODULE_DEVICE_TABLE(acpi, bme680_acpi_match);
> -
> static const struct of_device_id bme680_of_i2c_match[] = {
> { .compatible = "bosch,bme680", },
> {},
> @@ -57,7 +50,6 @@ MODULE_DEVICE_TABLE(of, bme680_of_i2c_match);
> static struct i2c_driver bme680_i2c_driver = {
> .driver = {
> .name = "bme680_i2c",
> - .acpi_match_table = ACPI_PTR(bme680_acpi_match),
> .of_match_table = bme680_of_i2c_match,
> },
> .probe = bme680_i2c_probe,
> --
> 2.25.1
>
--
With Best Regards,
Andy Shevchenko
