Re: [PATCH v1 1/2] iio: trigger: Replace explicit casting and wrong specifier with proper one

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Apr 2, 2021 at 4:25 PM Andy Shevchenko
<andy.shevchenko@xxxxxxxxx> wrote:
> On Friday, April 2, 2021, Jonathan Cameron <jic23@xxxxxxxxxx> wrote:
>> On Thu,  1 Apr 2021 17:54:56 +0300
>> Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx> wrote:
>>
>> > By unknown reason device name is set with an index casted from int
>> > to unsigned long while at the same time with "%ld" specifier. Both parts
>> > seems wrong to me, thus replace replace explicit casting and wrong specifier
>> > with proper one, i.e. "%u".
>> I'm not going to pretend to know what planet I was on when I wrote this :)
>
>
> Actually “%d” is even more correct (aligned with the type), but either will work.

I have noticed a typo in the commit message of the other patch.
I'll send a v2 altogether.

>> Series applied to the togreg branch of iio.git and pushed out as testing
>> for the autobuilders to poke at.


-- 
With Best Regards,
Andy Shevchenko




[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Input]     [Linux Kernel]     [Linux SCSI]     [X.org]

  Powered by Linux