On 01/04/21 4:00 pm, Jonathan Cameron wrote:
> On Thu, 1 Apr 2021 12:24:50 +0300
> Andy Shevchenko <andy.shevchenko@xxxxxxxxx> wrote:
>
>> On Thu, Apr 1, 2021 at 9:27 AM Mugilraj Dhavachelvan
>> <dmugil2000@xxxxxxxxx> wrote:
>>>
>>> Change function's name to %s and __func__ to fix checkpatch.pl errors.
>>
>> No, just drop the __func__ completely. First of all, we have a device
>> name, and uniqueness of the messages in the driver should guarantee
>> easy findings. Second, specific to _dbg() variants, with enabled
>> Dynamic Debug it can be chosen at run time!
>>
>> I recommend going through all drivers and drop __func__ near to
>> dev_dbg() and pr_debug().
>>
>
> Agreed. Though beware that some maintainers will count this
> as noise and get grumpy.
>
> I'm fine with such patches for IIO.
Sorry for the noise. I just seen the docs about dynamic debug.
So, if we use dev_dbg("log_msg") it will print statement like
filename:lineno [module]func flag log_msg, If I get it correctly.
And no need of specifying __func__ in dev_dbg() and dp_dbg() right!!
Jonathan do you have any TODO's?
>
> Jonathan
>
