On Fri, Mar 26, 2021 at 12:56 PM Andy Shevchenko <andy.shevchenko@xxxxxxxxx> wrote: > > On Thu, Mar 25, 2021 at 3:12 PM Lars-Peter Clausen <lars@xxxxxxxxxx> wrote: > > > > The inv_mpu6050 driver requires an interrupt for buffered capture. But non > > buffered reading for measurements works just fine without an interrupt > > connected. > > > > Make the interrupt optional to support this case. > > > > - irq_type = irqd_get_trigger_type(desc); > > - if (!irq_type) > > + irq_type = irqd_get_trigger_type(desc); > > + if (!irq_type) > > A side note: perhaps change this to comparison with IRQ_TYPE_NONE (as > a separate change)? And use actually IRQ_TYPE and not IRQF (the values are the same but semantics is different). I have seen that in many drivers :-( -- With Best Regards, Andy Shevchenko
