On Wed, 24 Mar 2021 11:45:14 -0700
Randy Dunlap <rdunlap@xxxxxxxxxxxxx> wrote:
> On 3/24/21 11:27 AM, Alexandru Ardelean wrote:
> > Because a dependency on HAS_IOMEM and OF was added for the ADI AXI ADC
> > driver, this makes the AD9467 driver have some build/dependency issues
> > when OF is disabled (typically on ACPI archs like x86).
> >
> > This is because the selection of the AD9467 enforces the ADI_AXI_ADC symbol
> > which is blocked by the OF (and potentially HAS_IOMEM) being disabled.
> >
> > To fix this, we make the AD9467 driver depend on the ADI_AXI_ADC symbol.
> > The AD9467 driver cannot operate on it's own. It requires the ADI AXI ADC
> > driver to stream data (or some similar IIO interface).
> >
> > So, the fix here is to make the AD9467 symbol depend on the ADI_AXI_ADC
> > symbol. At some point this could become it's own subgroup of high-speed
> > ADCs.
> >
> > Fixes: be24c65e9fa24 ("iio: adc: adi-axi-adc: add proper Kconfig dependencies")
> > Reported-by: Randy Dunlap <rdunlap@xxxxxxxxxxxxx>
> > Signed-off-by: Alexandru Ardelean <aardelean@xxxxxxxxxxx>
>
> Acked-by: Randy Dunlap <rdunlap@xxxxxxxxxxxxx>
Applied to the fixes-togreg branch of iio.git.
I'll do a pull request to Greg sometime in next few days for that
branch.
thanks,
Jonathan
>
> Thanks.
>
> > ---
> >
> > Apologies for this being too late.
> > I made the patch but forgot it in a local tree.
> >
> > Related to discussion:
> > https://lkml.org/lkml/2021/3/18/1007
> >
> > drivers/iio/adc/Kconfig | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/iio/adc/Kconfig b/drivers/iio/adc/Kconfig
> > index e0667c4b3c08..dda0f1e37ec1 100644
> > --- a/drivers/iio/adc/Kconfig
> > +++ b/drivers/iio/adc/Kconfig
> > @@ -249,7 +249,7 @@ config AD799X
> > config AD9467
> > tristate "Analog Devices AD9467 High Speed ADC driver"
> > depends on SPI
> > - select ADI_AXI_ADC
> > + depends on ADI_AXI_ADC
> > help
> > Say yes here to build support for Analog Devices:
> > * AD9467 16-Bit, 200 MSPS/250 MSPS Analog-to-Digital Converter
> >
>
>
