On 3/19/21 12:00 PM, William Breathitt Gray wrote:
> ERANGE is a semantically better error code to return when an argument
> value falls outside the supported limit range of a device.
>
> Cc: Syed Nayyar Waris <syednwaris@xxxxxxxxx>
> Cc: Oleksij Rempel <o.rempel@xxxxxxxxxxxxxx>
> Cc: Fabrice Gasnier <fabrice.gasnier@xxxxxx>
> Cc: Maxime Coquelin <mcoquelin.stm32@xxxxxxxxx>
> Cc: Alexandre Torgue <alexandre.torgue@xxxxxx>
> Reviewed-by: David Lechner <david@xxxxxxxxxxxxxx>
> Signed-off-by: William Breathitt Gray <vilhelm.gray@xxxxxxxxx>
> ---
> drivers/counter/104-quad-8.c | 6 +++---
> drivers/counter/interrupt-cnt.c | 3 +++
> drivers/counter/stm32-lptimer-cnt.c | 2 +-
> 3 files changed, 7 insertions(+), 4 deletions(-)
Hi William,
For the STM32 driver, you can add my:
Reviewed-by: Fabrice Gasnier <fabrice.gasnier@xxxxxxxxxxx>
Thanks,
Fabrice
>
> diff --git a/drivers/counter/104-quad-8.c b/drivers/counter/104-quad-8.c
> index b7d6c1c43655..0409b1771fd9 100644
> --- a/drivers/counter/104-quad-8.c
> +++ b/drivers/counter/104-quad-8.c
> @@ -154,7 +154,7 @@ static int quad8_count_write(struct counter_device *counter,
>
> /* Only 24-bit values are supported */
> if (val > 0xFFFFFF)
> - return -EINVAL;
> + return -ERANGE;
>
> mutex_lock(&priv->lock);
>
> @@ -669,7 +669,7 @@ static ssize_t quad8_count_preset_write(struct counter_device *counter,
>
> /* Only 24-bit values are supported */
> if (preset > 0xFFFFFF)
> - return -EINVAL;
> + return -ERANGE;
>
> mutex_lock(&priv->lock);
>
> @@ -714,7 +714,7 @@ static ssize_t quad8_count_ceiling_write(struct counter_device *counter,
>
> /* Only 24-bit values are supported */
> if (ceiling > 0xFFFFFF)
> - return -EINVAL;
> + return -ERANGE;
>
> mutex_lock(&priv->lock);
>
> diff --git a/drivers/counter/interrupt-cnt.c b/drivers/counter/interrupt-cnt.c
> index 0e07607f2cd3..f27dea317965 100644
> --- a/drivers/counter/interrupt-cnt.c
> +++ b/drivers/counter/interrupt-cnt.c
> @@ -107,6 +107,9 @@ static int interrupt_cnt_write(struct counter_device *counter,
> {
> struct interrupt_cnt_priv *priv = counter->priv;
>
> + if (val != (typeof(priv->count.counter))val)
> + return -ERANGE;
> +
> atomic_set(&priv->count, val);
>
> return 0;
> diff --git a/drivers/counter/stm32-lptimer-cnt.c b/drivers/counter/stm32-lptimer-cnt.c
> index 78f383b77bd2..49aeb9e393f3 100644
> --- a/drivers/counter/stm32-lptimer-cnt.c
> +++ b/drivers/counter/stm32-lptimer-cnt.c
> @@ -283,7 +283,7 @@ static ssize_t stm32_lptim_cnt_ceiling_write(struct counter_device *counter,
> return ret;
>
> if (ceiling > STM32_LPTIM_MAX_ARR)
> - return -EINVAL;
> + return -ERANGE;
>
> priv->ceiling = ceiling;
>
>
