On Wed, Mar 17, 2021 at 3:16 PM Andy Shevchenko
<andy.shevchenko@xxxxxxxxx> wrote:
>
> On Tue, Mar 16, 2021 at 11:24 PM Gwendal Grignou <gwendal@xxxxxxxxxxxx> wrote:
> >
> > fixes commit 2e2366c2d141 ("iio: cros_ec: unify hw fifo attributes into the core file")
> > fixes commit 165aea80e2e2 ("iio: cros_ec: use devm_iio_triggered_buffer_setup_ext()")
>
> Use the proper Fixes tag(s) in the tag block below.
>
> > 1. Instead of adding has_fw_fifo, deduct it from the configuration:
> > - EC must support FIFO (EC_FEATURE_MOTION_SENSE_FIFO) set.
> > - sensors send data a regular interval (accelerometer, gyro,
> > magnetomer, barometer, light sensor).
> > - "Legacy accelerometer" is only present on EC without FIFO, so we don't
> > need to set buffer attributes.
> >
> > 2. devm_iio_triggered_buffer_setup_ext() does not need to be called when
> > EC does not support FIFO, as there is no FIFO to manage.
> >
> > 3. Use devm_iio_triggered_buffer_setup_ext() when EC has a FIFO to
> > specify the buffer extended attributes.
>
> Sounds like three patches in one. Please, split and add proper Fixes
> tag(s) to each of them.
The code [at least] can be a single patch.
Albeit, it describes 3 different issues.
>
>
>
> --
> With Best Regards,
> Andy Shevchenko
