Hi, I love your patch! Perhaps something to improve: [auto build test WARNING on iio/togreg] [also build test WARNING on linux/master linus/master v5.12-rc2 next-20210311] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/alexandru-tachici-analog-com/iio-adc-ad7124-allow-more-than-8-channels/20210311-170758 base: https://git.kernel.org/pub/scm/linux/kernel/git/jic23/iio.git togreg config: openrisc-randconfig-m031-20210311 (attached as .config) compiler: or1k-linux-gcc (GCC) 9.3.0 If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <lkp@xxxxxxxxx> smatch warnings: drivers/iio/adc/ad7124.c:369 ad7124_init_config_vref() warn: inconsistent indenting vim +369 drivers/iio/adc/ad7124.c 356 357 static int ad7124_init_config_vref(struct ad7124_state *st, struct ad7124_channel_config *cfg) 358 { 359 unsigned int refsel = cfg->refsel; 360 361 switch (refsel) { 362 case AD7124_REFIN1: 363 case AD7124_REFIN2: 364 case AD7124_AVDD_REF: 365 if (IS_ERR(st->vref[refsel])) { 366 dev_err(&st->sd.spi->dev, 367 "Error, trying to use external voltage reference without a %s regulator.\n", 368 ad7124_ref_names[refsel]); > 369 return PTR_ERR(st->vref[refsel]); 370 } 371 cfg->vref_mv = regulator_get_voltage(st->vref[refsel]); 372 /* Conversion from uV to mV */ 373 cfg->vref_mv /= 1000; 374 return 0; 375 case AD7124_INT_REF: 376 cfg->vref_mv = 2500; 377 st->adc_control &= ~AD7124_ADC_CTRL_REF_EN_MSK; 378 st->adc_control |= AD7124_ADC_CTRL_REF_EN(1); 379 return ad_sd_write_reg(&st->sd, AD7124_ADC_CONTROL, 380 2, st->adc_control); 381 default: 382 dev_err(&st->sd.spi->dev, "Invalid reference %d\n", refsel); 383 return -EINVAL; 384 } 385 } 386 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all@xxxxxxxxxxxx
Attachment:
.config.gz
Description: application/gzip
