On Tue, Mar 9, 2021 at 11:37 AM Gwendal Grignou <gwendal@xxxxxxxxxxxx> wrote: > > iio_trigger_set_drvdata() sets the trigger device parent to first > argument of viio_trigger_alloc(), no need to do it again in the driver > code. > > Given we call devm_iio_trigger_alloc() and devm_iio_device_alloc() with > dev as parent, we do not have to set data->trig->dev.parent to > indio_dev->dev.parent anymore. > > Signed-off-by: Gwendal Grignou <gwendal@xxxxxxxxxxxx> Reviewed-by: Matt Ranostay <matt.ranostay@xxxxxxxxxxxx> > --- > Changes in v4: > Improve commit message. > > No changes in v3. > > drivers/iio/proximity/as3935.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/iio/proximity/as3935.c b/drivers/iio/proximity/as3935.c > index b79ada839e012..edc4a35ae66d1 100644 > --- a/drivers/iio/proximity/as3935.c > +++ b/drivers/iio/proximity/as3935.c > @@ -411,7 +411,6 @@ static int as3935_probe(struct spi_device *spi) > > st->trig = trig; > st->noise_tripped = jiffies - HZ; > - trig->dev.parent = indio_dev->dev.parent; > iio_trigger_set_drvdata(trig, indio_dev); > trig->ops = &iio_interrupt_trigger_ops; > > -- > 2.30.1.766.gb4fecdf3b7-goog >
