Re: [PATCH] iio: event_monitor: Enable events before monitoring

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Mar 4, 2021 at 5:00 PM Bastien Nocera <hadess@xxxxxxxxxx> wrote:

> If I'm not mistaken, "-a" does that for the iio_generic_buffer tool.

Yeah I implemented that, and I thought about doing the same here
but ... the name of the tool sort of announce that one want to
listen to all events so I thought it should just default-enable
all of them in this case.

> Maybe moving enable_disable_all_channels() to a common location and
> using that would cut down on the duplicated code?

The event enablement is slightly different, the generic buffer
turns on various channels, which is conceptually different
from various events, but let's see what Jonathan says.

We are sharing most of the code already in the iio-utils.c
but I can try to break out more if it doesn't get to abstract.

Thanks Bastien,
Linus Walleij



[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Input]     [Linux Kernel]     [Linux SCSI]     [X.org]

  Powered by Linux