On 2/12/21 6:13 AM, William Breathitt Gray wrote:
Only a select set of modes (function, action, etc.) are valid for a given device configuration. This patch ensures that invalid modes result in a return -EINVAL. Such a situation should never occur in reality, but it's good to define a default switch cases for the sake of making the intent of the code clear. Cc: Syed Nayyar Waris <syednwaris@xxxxxxxxx> Cc: Kamel Bouhara <kamel.bouhara@xxxxxxxxxxx> Cc: Fabrice Gasnier <fabrice.gasnier@xxxxxx> Cc: Maxime Coquelin <mcoquelin.stm32@xxxxxxxxx> Cc: Alexandre Torgue <alexandre.torgue@xxxxxx> Cc: David Lechner <david@xxxxxxxxxxxxxx> Signed-off-by: William Breathitt Gray <vilhelm.gray@xxxxxxxxx> ---
Reviewed-by: David Lechner <david@xxxxxxxxxxxxxx> (In response to Jonathan's comment, I think this is fine rather than adding more churn to change all of the breaks to returns - but will keep that in mind for future changes.)