Quoting Rob Herring (2021-02-09 13:13:47) > On Tue, Feb 02, 2021 at 10:44:33AM -0800, Stephen Boyd wrote: > > + description: Name for proximity sensor > > + > > +required: > > + - compatible > > + > > +unevaluatedProperties: false > > +additionalProperties: false > > Only need one. In this case 'additionalProperties'. Got it. > > > + > > +examples: > > + - | > > + spi { > > + #address-cells = <1>; > > + #size-cells = <0>; > > + ec@0 { > > + compatible = "google,cros-ec-spi"; > > + reg = <0>; > > + proximity { > > + compatible = "google,cros-ec-mkbp-proximity"; > > + label = "proximity-wifi-lte"; > > + }; > > The complete examples I prefer is 1 example for the whole MFD in the MFD > schema and no example here. Alright. I can add it to the mfd binding instead. > > > + }; > > + }; > > diff --git a/Documentation/devicetree/bindings/mfd/google,cros-ec.yaml b/Documentation/devicetree/bindings/mfd/google,cros-ec.yaml > > index 76bf16ee27ec..479a9f15de32 100644 > > --- a/Documentation/devicetree/bindings/mfd/google,cros-ec.yaml > > +++ b/Documentation/devicetree/bindings/mfd/google,cros-ec.yaml > > @@ -94,6 +94,9 @@ properties: > > keyboard-controller: > > $ref: "/schemas/input/google,cros-ec-keyb.yaml#"