Re: [PATCH] iio: ad7949: fix wrong ADC result due to incorrect bit mask

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sat, Feb 06, 2021 at 03:03:20PM +0100, Wilfried Wessner wrote:
> Signed-off-by: Wilfried Wessner <wilfried.wessner@xxxxxxxxx>

This needs to go after the changelog text.

> 
> Fixes a wrong bit mask used for the ADC's result, which was caused by an
> improper usage of the GENMASK() macro. The bits higher than ADC's 
> resolution are undefined and if not masked out correctly, a wrong result 
> can be given. The GENMASK() macro indexing is zero based, so the mask has 
> to go from [resolution -1 , 0].

You have trailing whitespace in your text, perhaps get your editor to
show you this?

Also, this is a new version of the patch, it needs to be marked as such
so we know which is the "latest".  The documentation says how to do
that.

thanks,

greg k-h



[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Input]     [Linux Kernel]     [Linux SCSI]     [X.org]

  Powered by Linux