Re: [PATCH] dt-bindings: iio: accel: bma255: Fix bmc150/bmi055 compatible

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, 15 Jan 2021 09:37:42 +0100
Stephan Gerhold <stephan@xxxxxxxxxxx> wrote:

> On Thu, Jan 14, 2021 at 08:59:37PM +0000, Jonathan Cameron wrote:
> > On Sun, 13 Dec 2020 13:25:14 +0000
> > Jonathan Cameron <jic23@xxxxxxxxxx> wrote:
> >   
> > > On Wed, 9 Dec 2020 12:17:39 -0600
> > > Rob Herring <robh@xxxxxxxxxx> wrote:
> > >   
> > > > On Wed, 02 Dec 2020 09:35:51 +0100, Stephan Gerhold wrote:    
> > > > > The bmc150-accel-i2c.c driver has an "_accel" suffix for the
> > > > > compatibles of BMC150 and BMI055. This is necessary because BMC150
> > > > > contains both accelerometer (bosch,bmc150_accel) and magnetometer
> > > > > (bosch,bmc150_magn) and therefore "bosch,bmc150" would be ambiguous.
> > > > > 
> > > > > However, the binding documentation suggests using "bosch,bmc150".
> > > > > Add the "_accel" suffix for BMC150 and BMI055 so the binding docs
> > > > > match what is expected by the driver.
> > > > > 
> > > > > Cc: Linus Walleij <linus.walleij@xxxxxxxxxx>
> > > > > Fixes: 496a39526fce8 ("iio: accel: bmc150-accel: Add DT bindings")
> > > > > Signed-off-by: Stephan Gerhold <stephan@xxxxxxxxxxx>
> > > > > ---
> > > > >  Documentation/devicetree/bindings/iio/accel/bosch,bma255.yaml | 4 ++--
> > > > >  1 file changed, 2 insertions(+), 2 deletions(-)
> > > > >       
> > > > 
> > > > Reviewed-by: Rob Herring <robh@xxxxxxxxxx>    
> > > Applied to the fixes-togreg branch of iio.git which is now based on stuff
> > > queued up for the merge window. I'll send a pull not long after rc1.
> > >   
> > 
> > Not sure why, but the Fixes tag above is invalid. 
> >   
> 
> I think we can call this a "race condition" :)
> 
> I sent the patch on Dec 02 and you rebased the patch on Dec 03 for
> "iio-for-5.11b-take2" (because some sign offs were missing there).
> My patch simply refers to the old commit hash.
> 
> Stephan

That would do it! :)

I suspected as much but was being lazy so didn't bother looking :)

Jonathan



[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Input]     [Linux Kernel]     [Linux SCSI]     [X.org]

  Powered by Linux