On Wed, Dec 9, 2020 at 7:16 AM Andy Shevchenko <andy.shevchenko@xxxxxxxxx> wrote: > > On Fri, Dec 4, 2020 at 10:40 PM Gwendal Grignou <gwendal@xxxxxxxxxxxx> wrote: > > > > Add timestamp channel: use standard procedure to collect timestamp. > > As some firmware do not notify on illuminance changes, add a > > do -> does Done in v2 > > > trigger to periodically query light. > > Sounds like two things in one change, you have to split. Done in v2 > > > We can either use the device trigger, or a software trigger like sysfs > > or hrtimer. > > > > This change is not backward compatible. > > You mean you are breaking ABI? It won't go like this. No, I was not setting a default trigger: on machines capable of sending ALS readout asynchronously, the user had to set a trigger in v1. Fixed in v2, now backward compatible. > > > To get samples from bios that > > bios -> BIOS Done in v2, submitting soon. > > > supports notification, we need to register the hardware trigger first: > > -- > With Best Regards, > Andy Shevchenko