Hi, On Wed, Dec 2, 2020 at 12:02 PM Stephen Boyd <swboyd@xxxxxxxxxxxx> wrote: > > This DT property can be 0, 16, and then 64, but not 32. The math here > doesn't recognize this slight bump in the power of 2 numbers and > translates a DT property of 64 into the register value '3' when it > really should be '2'. Fix it by subtracting one more if the number being > translated is larger than 31. Also use clamp() because we're here. > > Cc: Daniel Campello <campello@xxxxxxxxxxxx> > Cc: Lars-Peter Clausen <lars@xxxxxxxxxx> > Cc: Peter Meerwald-Stadler <pmeerw@xxxxxxxxxx> > Cc: Douglas Anderson <dianders@xxxxxxxxxxxx> > Cc: Gwendal Grignou <gwendal@xxxxxxxxxxxx> > Cc: Evan Green <evgreen@xxxxxxxxxxxx> > Signed-off-by: Stephen Boyd <swboyd@xxxxxxxxxxxx> > --- > > Changes from v2 (https://lore.kernel.org/r/20201120182944.543428-1-swboyd@xxxxxxxxxxxx): > * Use clamp() > * Add comment to clarify > > Changes from v1 (https://lore.kernel.org/r/20201120073842.3232458-1-swboyd@xxxxxxxxxxxx): > * Changed ternary to consider 17 to 31 as the same as 16 > > drivers/iio/proximity/sx9310.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) Reviewed-by: Douglas Anderson <dianders@xxxxxxxxxxxx>
