On Tue, 1 Dec 2020 13:28:47 +0100
Hans de Goede <hdegoede@xxxxxxxxxx> wrote:
> Hi,
>
> On 11/25/20 9:46 AM, Hans de Goede wrote:
> > Hi All,
> >
> > I wrote this because I was planning on using is_visible in a driver's
> > attribute group myself (1). But in the end it looks like I'm going to
> > do things differently.
> >
> > This is still useful to have though, both for possible future use of
> > is_visible in driver's attribute groups as well as to make the current
> > usage of is_visible in adi-axi-adc.c actually work.
>
> Jonathan, any opinion / remarks on this one?
>
> FWIW since I no longer have plans to use is_visible in an iio-driver
> myself I'm fine with dropping this one, but:
>
> 1. Being able to use is_visible in the attr group of iio-drivers
> seems like a nice thing to have.
>
> 2. There is an existing use of is_visible in adi-axi-adc.c which currently is broken.
I was giving time for Alex, or others to sanity check the need for a fix
(well more specifically wether this one was the right one as clearly
a need!).
Anyhow, all sounds good. Giving timing I'll mark it as one I'll pick up
to go in after rc1 + stable.
I'm not totally sure on the fixes tag. Current patch will have to go on top
of 207c2d27a010 ("iio: core: move channel list & group to private iio device object")
but I don't think it worked before that either as we were still copying attributes
around, just to a different location.
Jonathan
>
> Regards,
>
> Hans
>
>
>
>
> > 1) I was planning to add an (optional) in_accel_location attribute which
> > would contain "lid" or "base" on 360 degree hinges (yoga) style 2-in-1s
> > with 2 accelerometers and where the kernel knows the location. But given
> > the recent discussion to use label-s for this for proximity sensors,
> > I believe that using label-s here makes more sense too. I will write
> > a patch-set for this when I can find / make some time for this.
> >
>
