On Mon, 23 Nov 2020 11:02:58 +0800 Chen-Yu Tsai <wens@xxxxxxxx> wrote: > Hi, > > On Mon, Nov 23, 2020 at 2:22 AM Jonathan Cameron > <jic23@xxxxxxxxxxxxxxxxxxxxx> wrote: > > > > On Sat, 31 Oct 2020 18:48:39 +0000 > > Jonathan Cameron <jic23@xxxxxxxxxx> wrote: > > > > > From: Jonathan Cameron <Jonathan.Cameron@xxxxxxxxxx> > > > > > > This is a very small binding. It might make sense at some stage > > > to just roll it into the parent mfd. For now, converted as is. > > > The main advantage of this document is the identification of the > > > channel index values when this is used as a provider of ADC channels > > > to consumers. > > > > > > Signed-off-by: Jonathan Cameron <Jonathan.Cameron@xxxxxxxxxx> > > > Cc: Quentin Schulz <quentin.schulz@xxxxxxxxxxx> > > Quentin's email address is boucing so for now I've put myself as maintainer > > of this binding. > > > > +CC Chen-Yu Tsai who 'might' be the a better choice. > > Yes you can list me as the maintainer if you yourself don't wish to be. > I am listed as the maintainer for all AXP hardware, excluding the AXP288. > Great thanks - you are more likely to be able to answer questions on this than I am so I've put you in as maintainer + I'll get them anyway as IIO maintainer :) Jonathan > ChenYu > > > > Applied to the togreg branch of iio.git and pushed out as testing for > > the autobuilders to poke at it. > > > > Thanks, > > > > Jonathan > > > > > --- > > > .../bindings/iio/adc/axp20x_adc.txt | 48 ------------- > > > .../bindings/iio/adc/x-powers,axp209-adc.yaml | 67 +++++++++++++++++++ > > > 2 files changed, 67 insertions(+), 48 deletions(-) > > > > > > diff --git a/Documentation/devicetree/bindings/iio/adc/axp20x_adc.txt b/Documentation/devicetree/bindings/iio/adc/axp20x_adc.txt > > > deleted file mode 100644 > > > index 7a6313913923..000000000000 > > > --- a/Documentation/devicetree/bindings/iio/adc/axp20x_adc.txt > > > +++ /dev/null > > > @@ -1,48 +0,0 @@ > > > -* X-Powers AXP ADC bindings > > > - > > > -Required properties: > > > - - compatible: should be one of: > > > - - "x-powers,axp209-adc", > > > - - "x-powers,axp221-adc", > > > - - "x-powers,axp813-adc", > > > - - #io-channel-cells: should be 1, > > > - > > > -Example: > > > - > > > -&axp22x { > > > - adc { > > > - compatible = "x-powers,axp221-adc"; > > > - #io-channel-cells = <1>; > > > - }; > > > -}; > > > - > > > -ADC channels and their indexes per variant: > > > - > > > -AXP209 > > > ------- > > > - 0 | acin_v > > > - 1 | acin_i > > > - 2 | vbus_v > > > - 3 | vbus_i > > > - 4 | pmic_temp > > > - 5 | gpio0_v > > > - 6 | gpio1_v > > > - 7 | ipsout_v > > > - 8 | batt_v > > > - 9 | batt_chrg_i > > > -10 | batt_dischrg_i > > > - > > > -AXP22x > > > ------- > > > - 0 | pmic_temp > > > - 1 | batt_v > > > - 2 | batt_chrg_i > > > - 3 | batt_dischrg_i > > > - > > > -AXP813 > > > ------- > > > - 0 | pmic_temp > > > - 1 | gpio0_v > > > - 2 | batt_v > > > - 3 | batt_chrg_i > > > - 4 | batt_dischrg_i > > > diff --git a/Documentation/devicetree/bindings/iio/adc/x-powers,axp209-adc.yaml b/Documentation/devicetree/bindings/iio/adc/x-powers,axp209-adc.yaml > > > new file mode 100644 > > > index 000000000000..288a5ac31a16 > > > --- /dev/null > > > +++ b/Documentation/devicetree/bindings/iio/adc/x-powers,axp209-adc.yaml > > > @@ -0,0 +1,67 @@ > > > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > > > +%YAML 1.2 > > > +--- > > > +$id: http://devicetree.org/schemas/iio/adc/x-powers,axp209-adc.yaml# > > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > > + > > > +title: X-Powers AXP ADC bindings > > > + > > > +maintainers: > > > + - Quentin Schulz <quentin.schulz@xxxxxxxxxxx> > > > + > > > +description: | > > > + ADC is frequently used as a provider to consumers of the ADC channels. > > > + Device is a child of an axp209 multifunction device > > > + ADC channels and their indexes per variant: > > > + > > > + AXP209 > > > + ------ > > > + 0 | acin_v > > > + 1 | acin_i > > > + 2 | vbus_v > > > + 3 | vbus_i > > > + 4 | pmic_temp > > > + 5 | gpio0_v > > > + 6 | gpio1_v > > > + 7 | ipsout_v > > > + 8 | batt_v > > > + 9 | batt_chrg_i > > > + 10 | batt_dischrg_i > > > + > > > + AXP22x > > > + ------ > > > + 0 | pmic_temp > > > + 1 | batt_v > > > + 2 | batt_chrg_i > > > + 3 | batt_dischrg_i > > > + > > > + AXP813 > > > + ------ > > > + 0 | pmic_temp > > > + 1 | gpio0_v > > > + 2 | batt_v > > > + 3 | batt_chrg_i > > > + 4 | batt_dischrg_i > > > + > > > + > > > +properties: > > > + compatible: > > > + enum: > > > + - x-powers,axp209-adc > > > + - x-powers,axp221-adc > > > + - x-powers,axp813-adc > > > + > > > + "#io-channel-cells": > > > + const: 1 > > > + > > > +additionalProperties: false > > > + > > > +examples: > > > + - | > > > + axp221 { > > > + adc { > > > + compatible = "x-powers,axp221-adc"; > > > + #io-channel-cells = <1>; > > > + }; > > > + }; > > > +... > >