On Sat, 31 Oct 2020 18:48:14 +0000 Jonathan Cameron <jic23@xxxxxxxxxx> wrote: > From: Jonathan Cameron <Jonathan.Cameron@xxxxxxxxxx> > > Renamed to be more specific as I would be surprised if this is the only > sensorhub Samsung have ever shipped. > Fixed missing reg property in the example > > Signed-off-by: Jonathan Cameron <Jonathan.Cameron@xxxxxxxxxx> > Cc: Karol Wrona <k.wrona@xxxxxxxxxxx> Karol's email address is bouncing so I've put myself as maintainer of this binding. I'm more than happy to hand it over to someone else if anyone steps forward. Applied to the togreg branch of iio.git and pushed out as test for the autobuilders to possible poke at it. Thanks, Jonathan > --- > .../iio/samsung,sensorhub-rinato.yaml | 72 +++++++++++++++++++ > .../devicetree/bindings/iio/sensorhub.txt | 24 ------- > 2 files changed, 72 insertions(+), 24 deletions(-) > > diff --git a/Documentation/devicetree/bindings/iio/samsung,sensorhub-rinato.yaml b/Documentation/devicetree/bindings/iio/samsung,sensorhub-rinato.yaml > new file mode 100644 > index 000000000000..62366cbd37e5 > --- /dev/null > +++ b/Documentation/devicetree/bindings/iio/samsung,sensorhub-rinato.yaml > @@ -0,0 +1,72 @@ > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/iio/samsung,sensorhub-rinato.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Samsung Sensorhub driver > + > +maintainers: > + - Karol Wrona <k.wrona@xxxxxxxxxxx> > + > +description: | > + Sensorhub is a MCU which manages several sensors and also plays the role > + of a virtual sensor device. > + > +properties: > + compatible: > + enum: > + - samsung,sensorhub-rinato > + - samsung,sensorhub-thermostat > + > + reg: > + maxItems: 1 > + > + interrupts: > + maxItems: 1 > + > + ap-mcu-gpios: > + maxItems: 1 > + description: > + Application Processor to sensorhub line - used during communication > + > + mcu-ap-gpios: > + maxItems: 1 > + description: > + Sensorhub to Application Processor - used during communication > + > + mcu-reset-gpios: > + maxItems: 1 > + description: > + Reset the sensorhub. > + > + spi-max-frequency: true > + > +additionalProperties: false > + > +required: > + - compatible > + - reg > + - interrupts > + - ap-mcu-gpios > + - mcu-ap-gpios > + - mcu-reset-gpios > + > +examples: > + - | > + spi { > + #address-cells = <1>; > + #size-cells = <0>; > + > + sensorhub@0 { > + compatible = "samsung,sensorhub-rinato"; > + reg = <0>; > + spi-max-frequency = <5000000>; > + interrupt-parent = <&gpx0>; > + interrupts = <2 0>; > + ap-mcu-gpios = <&gpx0 0 0>; > + mcu-ap-gpios = <&gpx0 4 0>; > + mcu-reset-gpios = <&gpx0 5 0>; > + }; > + }; > +... > diff --git a/Documentation/devicetree/bindings/iio/sensorhub.txt b/Documentation/devicetree/bindings/iio/sensorhub.txt > deleted file mode 100644 > index b6ac0457d4ea..000000000000 > --- a/Documentation/devicetree/bindings/iio/sensorhub.txt > +++ /dev/null > @@ -1,24 +0,0 @@ > -Samsung Sensorhub driver > - > -Sensorhub is a MCU which manages several sensors and also plays the role > -of a virtual sensor device. > - > -Required properties: > -- compatible: "samsung,sensorhub-rinato" or "samsung,sensorhub-thermostat" > -- spi-max-frequency: max SPI clock frequency > -- interrupts: communication interrupt > -- ap-mcu-gpios: [out] ap to sensorhub line - used during communication > -- mcu-ap-gpios: [in] sensorhub to ap - used during communication > -- mcu-reset-gpios: [out] sensorhub reset > - > -Example: > - > - shub_spi: shub { > - compatible = "samsung,sensorhub-rinato"; > - spi-max-frequency = <5000000>; > - interrupt-parent = <&gpx0>; > - interrupts = <2 0>; > - ap-mcu-gpios = <&gpx0 0 0>; > - mcu-ap-gpios = <&gpx0 4 0>; > - mcu-reset-gpios = <&gpx0 5 0>; > - };