On Sat, Nov 14, 2020 at 03:46:41PM +0000, Jonathan Cameron wrote: > On Mon, 2 Nov 2020 15:22:25 +0100 > Bartosz Golaszewski <brgl@xxxxxxxx> wrote: > > > From: Bartosz Golaszewski <bgolaszewski@xxxxxxxxxxxx> > > > > When allocating an array of elements, users should check for > > multiplication overflow or preferably use one of the provided helpers > > like: devm_kmalloc_array(). > > > > This provides devm_krealloc_array() for users who want to reallocate > > managed arrays. > > > > Signed-off-by: Bartosz Golaszewski <bgolaszewski@xxxxxxxxxxxx> > > +CC Greg KH. > > As this is going into a very generic place I'd like a relevant ack. > That file is a bit of a wild west for acks, but Greg seems most > appropriate person. > > So Greg, any comments on this one? As there is only 1 user of this function in the patch series, you don't save any extra code space here, I don't think this is worth it. We are seeing less and less gains from these new devm_* additions, and only more confusion and problems with them. So perhaps don't add this? I don't think it is needed. thanks, greg k-h
