On Mon, 2 Nov 2020 15:22:24 +0100 Bartosz Golaszewski <brgl@xxxxxxxx> wrote: > From: Bartosz Golaszewski <bgolaszewski@xxxxxxxxxxxx> > > This is a follow-up to commit 750628c79bb1 ("iio: adc: xilinx-xadc: use > devm_krealloc()"). I noticed we can use even more devres helpers and entirely > drop the remove() callback. Given the generic nature of the additions to device.h I'm going to let this one sit a little longer for review. Remind me in a few weeks time if I seem to have lost it. Also, do a quick sanity check on whether I am fine to drop the platform_set_drvdata in the final patch. Thanks, Jonathan > > v1 -> v2: > - squash three patches adding more devres calls into one for easier review > - don't insist on the 80 characters limit > - add a new helper: devm_krealloc_array() and use it > > Bartosz Golaszewski (4): > device: provide devm_krealloc_array() > iio: adc: xilinx: use helper variable for &pdev->dev > iio: adc: xilinx: use devm_krealloc_array() instead of kfree() + > kcalloc() > iio: adc: xilinx: use more devres helpers and remove remove() > > drivers/iio/adc/xilinx-xadc-core.c | 151 +++++++++++++---------------- > include/linux/device.h | 11 +++ > 2 files changed, 80 insertions(+), 82 deletions(-) >