Re: [PATCH v2 16/29] dt-bindings:iio:dac:ti,dac082s085 yaml conversion

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sat, Oct 31, 2020 at 01:40:57PM +0000, Jonathan Cameron wrote:
> +  spi-cpha: true
> +  spi-cpol:
> +    description:
> +      Should be either spi-cpha, or spi-cpol but not both.

Do the YAML files follow RFC 2119 terminology?  If so, this is a
"must", not a "should".  (As it was in the txt file.)


> +required:
> +  - compatible
> +  - reg
> +  - vref-supply

This is missing "spi-cpha xor spi-cpol", not sure if it can be
specified here using the xor YAML trick.

Thanks,

Lukas



[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Input]     [Linux Kernel]     [Linux SCSI]     [X.org]

  Powered by Linux