On 10/29/20 8:49 AM, Coiby Xu wrote:
> SET_SYSTEM_SLEEP_PM_OPS has already took good care of CONFIG_PM_CONFIG.
>
> Signed-off-by: Coiby Xu <coiby.xu@xxxxxxxxx>
> ---
> drivers/iio/adc/stm32-adc.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/iio/adc/stm32-adc.c b/drivers/iio/adc/stm32-adc.c
> index b3f31f147347..42f9013730f8 100644
> --- a/drivers/iio/adc/stm32-adc.c
> +++ b/drivers/iio/adc/stm32-adc.c
> @@ -1988,7 +1988,6 @@ static int stm32_adc_remove(struct platform_device *pdev)
> return 0;
> }
>
> -#if defined(CONFIG_PM_SLEEP)
Hi Coiby,
This generates warnings when building with W=1 and CONFIG_PM_SLEEP=n.
Could you please add also "__maybe_unused" attribute in suspend / resume
routines below.
> static int stm32_adc_suspend(struct device *dev)
^
e.g. like: static int __maybe_unused stm32_adc_...
> {
> struct iio_dev *indio_dev = dev_get_drvdata(dev);
> @@ -2018,7 +2017,6 @@ static int stm32_adc_resume(struct device *dev)
>
> return stm32_adc_buffer_postenable(indio_dev);
> }
> -#endif
>
> #if defined(CONFIG_PM)
Same could be done also for runtime PM routines. For my own curiosity,
do you plan to do this as well ?
Best regards,
Fabrice
> static int stm32_adc_runtime_suspend(struct device *dev)
>
