Re: [RFC PATCH 2/2] iio: st-accel: Add support for Silan SC7A20 and SC7A30E

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Aug 20, 2020 at 10:01:00AM +0100, Jonathan Cameron wrote:
> 
> +CC: GregKH as this will pass through his tree.
> 
> As a quick summary, it seems we have some cloned parts that appear to be compatible
> with certain ST micro parts, but have different whoami address values.
> 
> Entirely reasonably, Denis is not happy to have them added to the ST maintained driver
> given the potential for future incompatibilities.
> 
> I don't particularly mind a separate driver, though I would ask that we remove
> a lot of the abstractions from the ST driver as they won't be necessary given
> the much more restricted parts being supported,
> 
> Greg, I'm guessing this is far from the first time this has happened.
> Any advise?

Yes, this happens all the time.  Do not create a whole new driver if at
all possible, that way lies duplicated work and madness.  Just add the
new ids or whatever to the existing driver and have everyone work with
it together.

"future incompatibilities" are never something to plan for, we can deal
with that when/if that ever happens.

thanks,

greg k-h



[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Input]     [Linux Kernel]     [Linux SCSI]     [X.org]

  Powered by Linux