On Mon, 10 Aug 2020 15:24:39 +0200 Christian Eggers <ceggers@xxxxxxx> wrote: > Hi Pavel, > > On Monday, 10 August 2020, 14:35:40 CEST, Pavel Machek wrote: > > On Mon 2020-08-10 11:57:46, Christian Eggers wrote: > > > On Monday, 10 August 2020, 11:00:54 CEST, Pavel Machek wrote: > > > > Hi! > > > > > > > > > The driver for the as73211 light sensor provides the following not yet > > > > > documented sysfs entries: > > > > > - in_intensity_(x|y|z)_raw > > > > > - in_intensity_(x|y|z)_scale > > > > > - in_intensity_sampling_frequency(_available) > > > > > - in_intensity_hardwaregain(_available) > > > > > > > > Should that be hardware_gain ? > > > > > > drivers/iio/industrialio-core.c: > > > [IIO_CHAN_INFO_HARDWAREGAIN] = "hardwaregain", > > > > Yep. Fix that before people start to really use it. > it's too late! IIO_CHAN_INFO_HARDWAREGAIN was introduced back in 2012. My > patch only adds "hardwaregain" in a new context (of "intensity"). Why do you think that is broken? It was a deliberate decision to try and stop putting _'s into new elements because it was making userspace parsing harder. hardwaregain is a single 'token' in that file name. We are stuck with some older forms that predate that decision and a few that are closely related to existing elements and hence had to maintain the 'spacing'. Those have to be special cased in tokenizing code. We don't want to introduced any more though. One or two may have snuck through when we weren't awake of course. Jonathan > > > > Pavel > > regards > Christian > > > > > ________________________________ > [http://assets.arri.com/media/sign/2020-04-03-E-mail-signature-Stellar2_V1.jpg] <https://microsites.arri.com/stellar/> > > Get all the latest information from www.arri.com<https://www.arri.com/>, Facebook<https://www.facebook.com/TeamARRI>, Twitter<https://twitter.com/ARRIChannel>, Instagram<https://instagram.com/arri> and YouTube<https://www.youtube.com/user/ARRIChannel>. > > Arnold & Richter Cine Technik GmbH & Co. Betriebs KG > Sitz: München - Registergericht: Amtsgericht München - Handelsregisternummer: HRA 57918 > Persönlich haftender Gesellschafter: Arnold & Richter Cine Technik GmbH > Sitz: München - Registergericht: Amtsgericht München - Handelsregisternummer: HRB 54477 > Geschäftsführer: Dr. Michael Neuhäuser; Stephan Schenk; Walter Trauninger; Markus Zeiler