On Thu, 13 Aug 2020 at 13:01, Andy Shevchenko <andy.shevchenko@xxxxxxxxx> wrote: > > On Thu, Aug 13, 2020 at 10:53 AM Crt Mori <cmo@xxxxxxxxxxx> wrote: > > > > There is some inconsistency and whitespace cleanup performed in this > > patch. It was done on top of my other patches, but I can rebase to head > > of the togreg branch if it would go in sooner. > > ... > > > -#define MLX90632_REF_12 12LL /**< ResCtrlRef value of Ch 1 or Ch 2 */ > > -#define MLX90632_REF_3 12LL /**< ResCtrlRef value of Channel 3 */ > > -#define MLX90632_MAX_MEAS_NUM 31 /**< Maximum measurements in list */ > > -#define MLX90632_SLEEP_DELAY_MS 3000 /**< Autosleep delay */ > > > > +#define MLX90632_REF_12 12LL /* ResCtrlRef value of Ch 1 or Ch 2 */ > > +#define MLX90632_REF_3 12LL /* ResCtrlRef value of Channel 3 */ > > +#define MLX90632_MAX_MEAS_NUM 31 /* Maximum measurements in list */ > > +#define MLX90632_SLEEP_DELAY_MS 3000 /* Autosleep delay */ > > #define MLX90632_EXTENDED_LIMIT 27000 /* Extended mode raw value limit */ > > This was actually in doxy (perhaps kernel doc also understands this) > format of description. > Can you double check that the kernel doc is okay / not okay with it? > > If it is okay, perhaps it's better to convert others to that format > rather than dropping it. > It is indeed from doxygen and looking at other drivers it should not be OK. I checked the docs and it does not say in fact. Maybe Jonathan knows, but he was already OK with these changes in v1. > -- > With Best Regards, > Andy Shevchenko
