On Fri, Jul 31, 2020 at 9:55 AM Christian Eggers <ceggers@xxxxxxx> wrote:
> On Thursday, 30 July 2020, 13:31:31 CEST, Andy Shevchenko wrote:
> > On Thu, Jul 30, 2020 at 1:52 PM Christian Eggers <ceggers@xxxxxxx> wrote:
...
> > > + * @buffer: Buffer for triggered measurements.
> > Actually Jonathan is correct -- the above has kernel doc issues.
> That's correct (the description for @buffer has to be removed). I didn't figure
> out how to automatically check for this. When building with V=1 C=1, I only get
> the message "as73211.c:76: info: Scanning doc for struct as73211_data".
W=1 (not V=1) runs kernel doc validation script.
...
> > > +static unsigned int as73211_gain(struct as73211_data *data)
> > > +{
> > >
> > > + return BIT(0xb - FIELD_GET(AS73211_CREG1_GAIN_MASK, data->creg1));
> >
> > Magic!
> Similarly it's difficult to find an eligible alias for the 0xb as the
> whole expression is constructed from viewing tables on the data sheet. I added
> some comment.
For this and the rest, descriptive comment is okay.
...
> > > + if (val < 0 || (freq_kHz * 1000) != val || val2)
> >
> > Ditto.
> I switched to existing defined where possible. But I wouldn't like to introduce
> this for every possible physical unit. Please check again in v4.
I'll do check.
--
With Best Regards,
Andy Shevchenko
