On Wed, Jul 22, 2020 at 5:28 PM Jonathan Cameron <jic23@xxxxxxxxxx> wrote:
>
> From: Jonathan Cameron <Jonathan.Cameron@xxxxxxxxxx>
>
> struct iio_chan_spec_ext_info shared element is of type
> enum iio_shared_by, not boolean. It's like the enum value
> will for IIO_SHARED_BY_TYPE == 1 == true, hence no actual
> problem has been observed.
>
> CC [M] drivers/iio/dac/ad5592r-base.o
> drivers/iio/dac/ad5592r-base.c:491:13: warning: implicit conversion from ‘enum <anonymous>’ to ‘enum iio_shared_by’ [-Wenum-conversion]
> 491 | .shared = true,
> |
> Fixes: 56ca9db862bf ("iio: dac: Add support for the AD5592R/AD5593R ADCs/DACs")
> Signed-off-by: Jonathan Cameron <Jonathan.Cameron@xxxxxxxxxx>
> Cc: Alexandru Ardelean <alexandru.ardelean@xxxxxxxxxx>
> ---
> drivers/iio/dac/ad5592r-base.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/iio/dac/ad5592r-base.c b/drivers/iio/dac/ad5592r-base.c
> index cc4875660a69..456bf5292c44 100644
> --- a/drivers/iio/dac/ad5592r-base.c
> +++ b/drivers/iio/dac/ad5592r-base.c
> @@ -488,7 +488,7 @@ static const struct iio_chan_spec_ext_info ad5592r_ext_info[] = {
> {
> .name = "scale_available",
> .read = ad5592r_show_scale_available,
> - .shared = true,
> + .shared = IIO_SHARED_BY_TYPE,
Acked-by: Alexandru Ardelean <alexandru.ardelean@xxxxxxxxxx>
> },
> {},
> };
> --
> 2.27.0
>
