Hi Guenter, On Mon, Jul 20, 2020 at 01:22:39PM -0700, Guenter Roeck wrote: > The EC reports a variety of error codes. Most of those, with the exception > of EC_RES_INVALID_VERSION, are converted to -EPROTO. As result, the actual > error code gets lost. In cros_ec_cmd_xfer_status(), convert all EC errors > to Linux error codes to report a more meaningful error to the caller to aid > debugging. > > To prepare for this change, handle error codes other than -EPROTO for all > callers of cros_ec_cmd_xfer_status(). Specifically, no longer assume that > -EPROTO reflects an error from the EC and all other error codes reflect a > transfer error. > > v2: Add patches 1/4 to 3/4 to handle callers of cros_ec_cmd_xfer_status() I did a rough grep to see what you might be missing: git grep -n EPROTO | grep -e cros -e '-ec' I think cros-ec-pwm / cros_ec_num_pwms() might need fixing too? Boy, I wrote that, but it sure ain't easy to read...(*checks watch*)...4 years later. Apart from the notes already made, I think the series looks good: Reviewed-by: Brian Norris <briannorris@xxxxxxxxxxxx> Feel free to CC me on v3, if you want another look Brian
