On Tue, Jul 21, 2020 at 10:34 PM Andy Shevchenko <andy.shevchenko@xxxxxxxxx> wrote: > > On Tue, Jul 21, 2020 at 2:27 PM Alexandru Ardelean > <alexandru.ardelean@xxxxxxxxxx> wrote: > > > > The driver pretty much uses device managed functions. The only left-over is > > the iio_device_register() function, which also requires an action-or-reset > > hook to disable the regulator on the remove and error path. > > > > Signed-off-by: Alexandru Ardelean <alexandru.ardelean@xxxxxxxxxx> > > ... > > > > + ret = devm_iio_device_register(&spi->dev, indio_dev); > > + if (ret == 0) > > > + dev_info(&spi->dev, "probed %s\n", indio_dev->name); > > > > return ret; > > Please, drop this useless spam (I agree here with Greg KH) and use simply > return devm_iio_...(...); I was also a bit undecided whether to keep it. Will drop. > > -- > With Best Regards, > Andy Shevchenko
