On Tue, Jul 21, 2020 at 8:16 PM Jonathan Cameron <jic23@xxxxxxxxxx> wrote: > > From: Jonathan Cameron <Jonathan.Cameron@xxxxxxxxxx> > > There is no real advantage in having these protections and > for parts that do not have an explicit ACPI ID, it prevents the > use of PRP0001. I'm trying to clear this out of IIO in general > to avoid copying in new drivers. > > Include mod_devicetable.h as we are using of_device_id in here so > including that header is best practice. Reviewed-by: Andy Shevchenko <andy.shevchenko@xxxxxxxxx> > Signed-off-by: Jonathan Cameron <Jonathan.Cameron@xxxxxxxxxx> > Cc: Angelo Compagnucci <angelo.compagnucci@xxxxxxxxx> > --- > v1->v2 > * Mention that some parts of valid IDs, so we are interesting in > enabling PRP0001 option for those that don't. > > drivers/iio/adc/ti-adc128s052.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/iio/adc/ti-adc128s052.c b/drivers/iio/adc/ti-adc128s052.c > index e86f55ce093f..3143f35a6509 100644 > --- a/drivers/iio/adc/ti-adc128s052.c > +++ b/drivers/iio/adc/ti-adc128s052.c > @@ -13,6 +13,7 @@ > #include <linux/err.h> > #include <linux/spi/spi.h> > #include <linux/module.h> > +#include <linux/mod_devicetable.h> > #include <linux/iio/iio.h> > #include <linux/property.h> > #include <linux/regulator/consumer.h> > @@ -220,7 +221,7 @@ MODULE_DEVICE_TABLE(acpi, adc128_acpi_match); > static struct spi_driver adc128_driver = { > .driver = { > .name = "adc128s052", > - .of_match_table = of_match_ptr(adc128_of_match), > + .of_match_table = adc128_of_match, > .acpi_match_table = ACPI_PTR(adc128_acpi_match), > }, > .probe = adc128_probe, > -- > 2.27.0 > -- With Best Regards, Andy Shevchenko