On Wed, Jul 15, 2020 at 08:44:59AM +0300, Andy Shevchenko wrote:
> On Wed, Jul 15, 2020 at 8:05 AM Dan Robertson <dan@xxxxxxxxxxxxxxx> wrote:
> >
> > - Add system sleep ops if CONFIG_PM_SLEEP is set.
> > - Add attribute for setting the power mode of the
> > device.
>
> ...
>
> > -static const struct iio_chan_spec_ext_info bma400_ext_info[] = {
>
> > -};
> > -
> > -#define BMA400_ACC_CHANNEL(_axis) { \
>
> > -}
> > -
> > -static const struct iio_chan_spec bma400_channels[] = {
>
> > -};
> > -
>
> I'm not sure how this part is related.
>
> ...
Moving things around for the power mode switching endpoint.
> > +static const char * const bma400_power_modes[] = {
> > + "sleep",
> > + "low-power",
> > + "normal"
>
> Missed comma.
>
> > +};
>
> ...
>
> > +#ifdef CONFIG_PM_SLEEP
>
> __maybe_unused looks better.
Good point.
Thanks for the review! I'll address your comments in v2 of the patchset.
Cheers,
- Dan
Attachment:
signature.asc
Description: PGP signature
