On Sat, Jul 4, 2020 at 6:59 PM Jonathan Cameron <jic23@xxxxxxxxxx> wrote: > > On Tue, 30 Jun 2020 10:25:24 +0300 > Andy Shevchenko <andy.shevchenko@xxxxxxxxx> wrote: > > > On Sun, Jun 28, 2020 at 3:39 PM Jonathan Cameron <jic23@xxxxxxxxxx> wrote: > > > > > > From: Jonathan Cameron <Jonathan.Cameron@xxxxxxxxxx> > > > > > > Whilst it's unlikely that this driver will ever be instantiated from > > > ACPI PRP0001 there is little advantage in using the of_match_ptr > > > protection. The switch of header is because we only use of_match_id > > > in here and that is defined in mod_devicetable.h not of.h. > > > > > > Note the main reason for this patch is to avoid providing instances > > > of of_match_ptr being used in IIO that might get copied into new drivers. > > > > > > > Commit message is misleading. The change won't help with ACPI due to > > syscon_regmap_lookup_by_phandle() call. > > I'd missed that. I'll drop this one. Actually in this case, if it's not done yet, I prefer to see in Kconfig something like depends on OF || COMPILE_TEST to explicitly show that "yes, you may compile it, but it requires OF to function with usefulness". -- With Best Regards, Andy Shevchenko
