On Sat, Jul 4, 2020 at 6:55 PM Jonathan Cameron <jic23@xxxxxxxxxx> wrote: > > On Tue, 30 Jun 2020 10:20:55 +0300 > Andy Shevchenko <andy.shevchenko@xxxxxxxxx> wrote: > > > On Sun, Jun 28, 2020 at 3:39 PM Jonathan Cameron <jic23@xxxxxxxxxx> wrote: > > > > > > From: Jonathan Cameron <Jonathan.Cameron@xxxxxxxxxx> > > > > > > Although this driver has an explicit ACPI binding it is good to also > > > allow for PRP0001 use of the of_match_id table. > > > > > > I'm also trying to clean this (now) anti-pattern out of IIO to avoid > > > cut and paste into new drivers. > > > > > > Also add an include of mod_devicetable.h as the driver directly uses > > > struct of_device_id which is defined in there. > > > > > > > I think this is not needed. At least the commit message in this case > > is misleading. > > We have only one ID and ACPI already has it. So, there is no need for > > this patch from that perspective. > > It would be a bit odd if non Intel boards used an Intel ID for a TI > part. Particularly I as can't immediately find any public docs > of the ID. Do you know if these are documented publicly anywhere? Unfortunately it's vendor specific stuff, only vendor prefixes are documented on uefi.org. And it's fine to use an already existing ID for the component from the same company. The thing is that this is a really discrete component from TI on Intel Galileo board. > I know we don't do this in an ideal fashion as we have an internal > registry but I don't think we publish it anywhere, but then we don't > really expect anyone else to use them. I'm not aware of us having > issued IDs for parts made by anyone other than ourselves. > > So in general I'd rather we gave the option for using the dt binding > PRP0001 route in addition to the intel ACPI ID. I'm not against the clean up in code, but I don't think it is good to encourage users to use PRP0001 when the ACPI ID is already allocated (doesn't matter by whom). So, I would recommend to leave the change, but rephrase the commit message to avoid PRP0001 mentioning. -- With Best Regards, Andy Shevchenko
