On Mon, 8 Jun 2020 14:12:18 +0200 Linus Walleij <linus.walleij@xxxxxxxxxx> wrote: > Hi Jonathan, > > sorry for missing this :( > > On Sun, May 31, 2020 at 4:00 PM Jonathan Cameron <jic23@xxxxxxxxxx> wrote: > > On Tue, 26 May 2020 13:13:56 +0200 > > Linus Walleij <linus.walleij@xxxxxxxxxx> wrote: > > > > > On Tue, May 26, 2020 at 12:47 PM Dinghao Liu <dinghao.liu@xxxxxxxxxx> wrote: > > > > > > > When devm_regmap_init_i2c() returns an error code, a pairing > > > > runtime PM usage counter decrement is needed to keep the > > > > counter balanced. For error paths after ak8974_set_power(), > > > > ak8974_detect() and ak8974_reset(), things are the same. > > > > > > > > However, When iio_triggered_buffer_setup() returns an error > > > > code, there will be two PM usgae counter decrements. > > > > > > > > Signed-off-by: Dinghao Liu <dinghao.liu@xxxxxxxxxx> > > > > --- > > > > > > > > Changelog: > > > > > > > > v2: - Change 3 goto targets from "power_off" to > > > > "disabel_pm". Remove unused lable "power_off". > > > > Move 3 PM runtime related calls to the end of > > > > the function. > > > > > > Thanks for fixing this Dinghao! > > > Reviewed-by: Linus Walleij <linus.walleij@xxxxxxxxxx> > > > > Could I have a fixes tag for this one? > > It's been there since the beginning so: > Fixes: 7c94a8b2ee8c ("iio: magn: add a driver for AK8974") There was a lot of fuzz in this one due to other changes to the driver. I 'think' it went it cleanly though. Applied to the fixes-togreg branch of iio.git and marked for stable. Thanks, Jonathan > > Yours, > Linus Walleij