On Mon, Jun 08, 2020 at 10:24:11AM +0000, Jean-Baptiste Maneyrol wrote: > Hi Jonathan, > > as stated before, I think this is a good opportunity to fix FIFO data reading by replacing regmap_bulk_read by regmap_noinc_read. > Otherwise it could also be done in another patch. It seems I didn't get this series to my work email, so, sorry for answering here. > - result = regmap_bulk_read(st->map, st->reg->fifo_count_h, data, > + result = regmap_bulk_read(st->map, st->reg->fifo_count_h, > + st->data, > INV_MPU6050_FIFO_COUNT_BYTE); Now this can be one line :-) ... > - iio_push_to_buffers_with_timestamp(indio_dev, data, timestamp); > + iio_push_to_buffers_with_timestamp(indio_dev, st->data, > + timestamp); And this seems redundant change. -- With Best Regards, Andy Shevchenko