On Wed, 3 Jun 2020 10:44:41 +0200 Tomasz Duszynski <tomasz.duszynski@xxxxxxxxxxx> wrote: > Add SCD30 sensor binding file. > > Signed-off-by: Tomasz Duszynski <tomasz.duszynski@xxxxxxxxxxx> Looks fine to me (as do the previous 2 patches), however I'd ideally like to leave time for a DT review from Rob. Thanks, Jonathan > --- > .../iio/chemical/sensirion,scd30.yaml | 68 +++++++++++++++++++ > MAINTAINERS | 1 + > 2 files changed, 69 insertions(+) > create mode 100644 Documentation/devicetree/bindings/iio/chemical/sensirion,scd30.yaml > > diff --git a/Documentation/devicetree/bindings/iio/chemical/sensirion,scd30.yaml b/Documentation/devicetree/bindings/iio/chemical/sensirion,scd30.yaml > new file mode 100644 > index 000000000000..40d87346ff4c > --- /dev/null > +++ b/Documentation/devicetree/bindings/iio/chemical/sensirion,scd30.yaml > @@ -0,0 +1,68 @@ > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/iio/chemical/sensirion,scd30.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Sensirion SCD30 carbon dioxide sensor > + > +maintainers: > + - Tomasz Duszynski <tomasz.duszynski@xxxxxxxxxxx> > + > +description: | > + Air quality sensor capable of measuring co2 concentration, temperature > + and relative humidity. > + > +properties: > + compatible: > + enum: > + - sensirion,scd30 > + > + reg: > + maxItems: 1 > + > + interrupts: > + maxItems: 1 > + > + vdd-supply: true > + > + sensirion,sel-gpios: > + description: GPIO connected to the SEL line > + maxItems: 1 > + > + sensirion,pwm-gpios: > + description: GPIO connected to the PWM line > + maxItems: 1 > + > +required: > + - compatible > + > +additionalProperties: false > + > +examples: > + - | > + # include <dt-bindings/interrupt-controller/irq.h> > + i2c { > + #address-cells = <1>; > + #size-cells = <0>; > + > + co2-sensor@61 { > + compatible = "sensirion,scd30"; > + reg = <0x61>; > + vdd-supply = <&vdd>; > + interrupt-parent = <&gpio0>; > + interrupts = <0 IRQ_TYPE_LEVEL_HIGH>; > + }; > + }; > + - | > + # include <dt-bindings/interrupt-controller/irq.h> > + serial { > + co2-sensor { > + compatible = "sensirion,scd30"; > + vdd-supply = <&vdd>; > + interrupt-parent = <&gpio0>; > + interrupts = <0 IRQ_TYPE_LEVEL_HIGH>; > + }; > + }; > + > +... > diff --git a/MAINTAINERS b/MAINTAINERS > index 5db4b446c8ba..0ab9cf39e051 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -15140,6 +15140,7 @@ F: include/uapi/linux/phantom.h > SENSIRION SCD30 CARBON DIOXIDE SENSOR DRIVER > M: Tomasz Duszynski <tomasz.duszynski@xxxxxxxxxxx> > S: Maintained > +F: Documentation/devicetree/bindings/iio/chemical/sensirion,scd30.yaml > F: drivers/iio/chemical/scd30.h > F: drivers/iio/chemical/scd30_core.c > F: drivers/iio/chemical/scd30_i2c.c