Re: [PATCH] iio: chemical: atlas-ezo-sensor: move ret variable scope in atlas_ezo_read_raw()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sun, 31 May 2020 06:02:08 +0300
Matt Ranostay <matt.ranostay@xxxxxxxxxxxx> wrote:

> Move ret variable to the IIO_CHAN_INFO_RAW switch since currently
> only used within that scope.
> 
> Signed-off-by: Matt Ranostay <matt.ranostay@xxxxxxxxxxxx>

Applied to the togreg branch of iio.git and pushed out as testing
for the autobuilders to play with it.

Thanks,

Jonathan

> ---
>  drivers/iio/chemical/atlas-ezo-sensor.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/iio/chemical/atlas-ezo-sensor.c b/drivers/iio/chemical/atlas-ezo-sensor.c
> index f5a6d8ec6d4d..a94eb8a6bf32 100644
> --- a/drivers/iio/chemical/atlas-ezo-sensor.c
> +++ b/drivers/iio/chemical/atlas-ezo-sensor.c
> @@ -69,13 +69,13 @@ static int atlas_ezo_read_raw(struct iio_dev *indio_dev,
>  {
>  	struct atlas_ezo_data *data = iio_priv(indio_dev);
>  	struct i2c_client *client = data->client;
> -	int ret = 0;
>  
>  	if (chan->type != IIO_CONCENTRATION)
>  		return -EINVAL;
>  
>  	switch (mask) {
>  	case IIO_CHAN_INFO_RAW: {
> +		int ret;
>  		long tmp;
>  
>  		mutex_lock(&data->lock);
> @@ -110,7 +110,7 @@ static int atlas_ezo_read_raw(struct iio_dev *indio_dev,
>  		return IIO_VAL_INT_PLUS_MICRO;
>  	}
>  
> -	return ret;
> +	return 0;
>  }
>  
>  static const struct iio_info atlas_info = {




[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Input]     [Linux Kernel]     [Linux SCSI]     [X.org]

  Powered by Linux