On Tue, 21 Apr 2020 08:37:13 +0800 Chris Ruehl <chris.ruehl@xxxxxxxxxxxx> wrote: > Jonathan, > > On 17/4/2020 5:23 pm, Jonathan Cameron wrote: > > On Thu, 16 Apr 2020 11:48:31 +0800 > > Chris Ruehl <chris.ruehl@xxxxxxxxxxxx> wrote: > > > >> Hi, > >> > >> I'm working on implementation for ltc6602 dual match bandpass > >> filter spi driver. > >> The driver tree has a iio/frequency which has PLLs at time beeing > >> and I wondering to drop my driver there or have a new directory > >> freqfilter or bpf ? > >> > >> This isn't urgent, but would be nice to know. > >> > > Perhaps iio/afe? It's a type of analog front end (or might be used > > as such). Is the intent to wrap these up as a consumer of an ADC? > > So they ultimately provide a unified device presentation to > > userspace of the ADC + filters. Or are we looking at simply > > controlling a filter which doesn't connect to an ADC or DAC visible > > to us? > > > > I'm not against a new directory for filters though. Don't be > > specific on the type unless we need to be :) > > > > Jonathan > I place the driver into afe, makes totally sense to me, but have to > create a directory > linux/iio/afe which is not existing while I write this. curious. It was introduced in 4.18. What tree are you working on top of? > > will be then: > drivers/iio/afe/ltc6602.c > include/linux/iio/afe/ltc6602.h possibly on the header, but most IIO drivers don't have their own header. For kernel code it is preferred to put as much as possible directly in the c file. The exceptions are drivers needing multiple files or where the header is used in conjunction with a DT binding. > add entry to drivers/iio/afe/Kconfig + Makefile. > > If i have the driver ready and checked I send my patches Great. Jonathan > > Cheers > Chris > > >> Regards > >> Chris > > >
