On Mon, 2020-04-13 at 10:38 +0200, Lars Engebretsen wrote: > Hi all, > > I just came across a small thing: I think that there is an erroneous > semicolon at the end of line 603 in include/linux/iio/iio.h yep; good find :) > > https://urldefense.com/v3/__https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/include/linux/iio/iio.h?h=v5.7-rc1*n602__;Iw!!A3Ni8CS0y2Y!rXR19w3XDkuxpdAY4teDN4bSsfqvea7Sz5ZW26L2TCEeYhwf1mgTjt63tIp3Xld9oFWgcg$ > > I'm completely new to kernel development, so I don't know the process for > submitting patches. Moreover, the macro seems to be gone in git:// > git.kernel.org/pub/scm/linux/kernel/git/jic23/iio.git so maybe the issue > has been fixed already? In any case, I'd be happy to submit a patch if that > is the right thing to do. But then I'd need a bit of help to get started. > You're probably looking at the wrong branch. It's a good idea to look at the ones that have been updated more recently. It's still there. Check 'togreg' or 'testing'. I suggest editing those. Look for patterns in the commit title & descriptions, don't forget to add your Signed-off-by tag with 'git commit -s' If you want, an idea for a commit title would be: 'iio: core: remove extra semi-colon from devm_iio_device_register() macro' Add a comment describing the change. Generate the patch with: git format-patch HEAD~1.. then run ./scripts/get_maintainers.pl <patch-file> The output suggests which lists to target. What I do, is put lists with --to=<list>, maintainers [other people] with -- cc=<maintainer> --cc=<driver-author> --cc=<other-potentially-interested-people> You first need to configure git-email to send emails; there should be some docs on the web about that. Lastly: git send-email --to=linux-iio@xxxxxxxxxxxxxxx --to=linux-kernel@xxxxxxxxxxxxxxx --cc=jic@xxxxxxxxxx <patch-file> That's roughly it. We should see your patch on the list. https://lore.kernel.org/linux-iio/ & https://patchwork.kernel.org/project/linux-iio/list/ > Thanks, > Lars
