On Thu, 9 Apr 2020 20:41:23 +0530 Aishwarya R <aishwaryarj100@xxxxxxxxx> wrote: > Use the helper function that wraps the calls to > platform_get_resource() and devm_ioremap_resource() > together. > > Signed-off-by: Aishwarya R <aishwaryarj100@xxxxxxxxx> Hi Aishwarya R, Thanks for the patch. Good to add a little more detail to the description and note that I do prefer one patch per driver for IIO drivers. One other thing. Please use full name for the signed-off-by. I see you use a longer form in your email later in the thread. The DCO is a formal legal statement https://www.kernel.org/doc/html/v4.17/process/submitting-patches.html#sign-your-work-the-developer-s-certificate-of-origin so we tend to be fussy! Thanks, Jonathan > --- > drivers/iio/adc/at91_adc.c | 5 +---- > 1 file changed, 1 insertion(+), 4 deletions(-) > > diff --git a/drivers/iio/adc/at91_adc.c b/drivers/iio/adc/at91_adc.c > index abe99856c823..0368b6dc6d60 100644 > --- a/drivers/iio/adc/at91_adc.c > +++ b/drivers/iio/adc/at91_adc.c > @@ -1152,7 +1152,6 @@ static int at91_adc_probe(struct platform_device *pdev) > int ret; > struct iio_dev *idev; > struct at91_adc_state *st; > - struct resource *res; > u32 reg; > > idev = devm_iio_device_alloc(&pdev->dev, sizeof(struct at91_adc_state)); > @@ -1182,9 +1181,7 @@ static int at91_adc_probe(struct platform_device *pdev) > if (st->irq < 0) > return -ENODEV; > > - res = platform_get_resource(pdev, IORESOURCE_MEM, 0); > - > - st->reg_base = devm_ioremap_resource(&pdev->dev, res); > + st->reg_base = devm_platform_ioremap_resource(pdev, 0); > if (IS_ERR(st->reg_base)) > return PTR_ERR(st->reg_base); >
