On Tue, Apr 07, 2020 at 04:22:38PM +0200, Maxime Ripard wrote: > On Tue, Apr 07, 2020 at 01:03:39PM +0200, Kamel Bouhara wrote: > > > On Mon, Apr 06, 2020 at 05:58:05PM +0200, Kamel Bouhara wrote: > > > > Add dt binding for the counter variant of the rotary encoder driver. > > > > > > > > Signed-off-by: Kamel Bouhara <kamel.bouhara@xxxxxxxxxxx> > > > > --- > > > > .../input/rotary-encoder-counter.yaml | 67 +++++++++++++++++++ > > > > 1 file changed, 67 insertions(+) > > > > create mode 100644 Documentation/devicetree/bindings/input/rotary-encoder-counter.yaml > > > > > > > > diff --git a/Documentation/devicetree/bindings/input/rotary-encoder-counter.yaml b/Documentation/devicetree/bindings/input/rotary-encoder-counter.yaml > > > > new file mode 100644 > > > > index 000000000000..a59f7c1faf0c > > > > --- /dev/null > > > > +++ b/Documentation/devicetree/bindings/input/rotary-encoder-counter.yaml > > > > @@ -0,0 +1,67 @@ > > > > +# SPDX-License-Identifier: GPL-2.0 > > > > > > Bindings are usually used by other OS's, so you should consider > > > putting it under a more permissive license, usually that would be GPL2 > > > and the BSD-2-Clause > > > > Well to be honest I just looked into an existing binding and I guess > > the wrong one :). > > Not the wrong ones, but the old ones :) > > It's painful to change a license on existing files, whereas it's > pretty easy to mention it during review. > Alright. > > > > +%YAML 1.2 > > > > +--- > > > > +$id: http://devicetree.org/schemas/input/rotary-encoder-counter.yaml# > > > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > > > + > > > > +title: Rotary Encoder Counter > > > > + > > > > +maintainers: > > > > + - Kamel Bouhara <kamel.bouhara@xxxxxxxxxxx> > > > > + > > > > +description: > > > > + Registers a Rotary encoder connected through a counter device. > > > > > > You shouldn't really describe the action here, but more what the > > > binding is about. The registration will not depend on the presence of > > > the node following that binding, but rather on whether or not the OS > > > that uses it has support for it. > > > > > > > Then shall it be better with just : > > "A rotary encoder device using a generic counter interface." ? > > The generic counter interface is a Linux-only stuff though, some other > OS might want to implement something else. Something like "based on a > counter"? > Indeed, that's fair enough. Thanks. > Maxime -- Kamel Bouhara, Bootlin Embedded Linux and kernel engineering https://bootlin.com
