Re: [v2] iio: core: move 'indio_dev->info' null check first

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



>     Doesn't fix anything.

You would like to change something for a specific reason.
Thus please omit this sentence.


>     Just moves this to be the first check, as it's very …

Wording alternative:
Move a null pointer check to the beginning of this function implementation.


>     This is a minor optimization, since '__iio_device_register()' will waste
>     fewer validation cycles in case 'indio_dev->info' is NULL.

How do you think about to use the text “iio: core: Improve input parameter validation
in __iio_device_register()” as a commit subject?

Regards,
Markus




[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Input]     [Linux Kernel]     [Linux SCSI]     [X.org]

  Powered by Linux