On Tue, Apr 7, 2020 at 1:38 PM Sa, Nuno <Nuno.Sa@xxxxxxxxxx> wrote: > > > > > > > + irq_type = irqd_get_trigger_type(desc); > > > > For the sake of consistency I would assign irq_flag here as well. > > > > > > > > > > The library will do it by default, But that's me using "inside" info... or maybe > > if > > > I document that in patch 2 (the struct kernel docs) we would not really > > need to > > > assign it here? > > > > I see now. From my point of view the library here does an ill turn > > because it hides some details which driver needs to do anyway. > > I prefer explicit over implicit at least here. > > > > Let's explicitly assign the irq_flag then... > > > I would say okay, if there is no such code (like below) would be > > present in the driver. > > Now that I think about, this is actually code that, probably, could go inside the > library since this is pretty standard for this kind of devices. Anyways, that's > another story... It would be awesome if you can do that! Yes, it probably will require a separate series. -- With Best Regards, Andy Shevchenko
