On Mon, 6 Apr 2020 17:15:21 +0530 Jishnu Prakash <jprakash@xxxxxxxxxxxxxx> wrote: > Hi Jonathan, > > On 3/28/2020 10:24 PM, Jonathan Cameron wrote: > > On Tue, 24 Mar 2020 21:14:09 +0530 > > Jishnu Prakash <jprakash@xxxxxxxxxxxxxx> wrote: > > > >> Add documentation for PMIC7 ADC peripheral. For PMIC7 ADC, all SW > >> communication to ADC goes through PMK8350, which communicates with > >> other PMICs through PBS. > >> > >> Signed-off-by: Jishnu Prakash <jprakash@xxxxxxxxxxxxxx> > >> --- > >> .../bindings/iio/adc/qcom,spmi-vadc.yaml | 28 ++++++++++++++++------ > >> 1 file changed, 21 insertions(+), 7 deletions(-) > >> > >> diff --git a/Documentation/devicetree/bindings/iio/adc/qcom,spmi-vadc.yaml b/Documentation/devicetree/bindings/iio/adc/qcom,spmi-vadc.yaml > >> index 72db14c..20f010c 100644 > >> --- a/Documentation/devicetree/bindings/iio/adc/qcom,spmi-vadc.yaml > >> +++ b/Documentation/devicetree/bindings/iio/adc/qcom,spmi-vadc.yaml > >> @@ -13,7 +13,7 @@ maintainers: > >> description: | > >> SPMI PMIC voltage ADC (VADC) provides interface to clients to read > >> voltage. The VADC is a 15-bit sigma-delta ADC. > >> - SPMI PMIC5 voltage ADC (ADC) provides interface to clients to read > >> + SPMI PMIC5/PMIC7 voltage ADC (ADC) provides interface to clients to read > >> voltage. The VADC is a 16-bit sigma-delta ADC. > >> > >> properties: > >> @@ -23,6 +23,7 @@ properties: > >> - qcom,spmi-adc5 > >> - qcom,spmi-adc-rev2 > >> - qcom,pms405-adc > >> + - qcom,spmi-adc7 > >> > >> reg: > >> description: VADC base address in the SPMI PMIC register map > >> @@ -65,6 +66,8 @@ patternProperties: > >> description: | > >> ADC channel number. > >> See include/dt-bindings/iio/qcom,spmi-vadc.h > >> + For PMIC7 ADC, the channel numbers are specified separately per PMIC > >> + in the PMIC-specific files in include/dt-bindings/iio/. > > That makes me thing we really should have separate compatibles. The > > parts clearly have differences, even if we haven't needed to use them > > explicitly as yet. > I'm not sure what you mean by this. We have added a new compatible > property "qcom,spmi-adc7" for PMIC7 ADC. I've no idea what I meant either :) Jonathan > > > >> > >> label: > >> description: | > >> @@ -72,7 +75,7 @@ patternProperties: > >> For thermistor inputs connected to generic AMUX or GPIO inputs > >> these can vary across platform for the same pins. Hence select > >> the platform schematics name for this channel. It is required > >> - for "qcom,spmi-adc5" and "qcom,spmi-adc-rev2". > >> + for "qcom,spmi-adc5", "qcom,spmi-adc7" and "qcom,spmi-adc-rev2". > >> allOf: > >> - $ref: /schemas/types.yaml#/definitions/string > >> > >>
