HI On 4/1/2020 9:58 PM, Richard Neumann wrote: > Am Dienstag, den 31.03.2020, 20:24 +0300 schrieb Andy Shevchenko: >> On Tue, Mar 31, 2020 at 4:26 PM Shah, Nehal-bakulchandra >> <nehal-bakulchandra.shah@xxxxxxx> wrote: >>> On 3/31/2020 6:01 PM, Richard Neumann wrote: >>>> Not a real review, but your patch series seems to be repeating a >>>> lot >>>> from drivers/i2c/busses/i2c-amd-mp2*. >>>> Is there any chance we could re-use the code? >>>> E.g. the AMD_C2P_* definitions from drivers/i2c/busses/i2c-amd- >>>> mp2.h? >>> Thanks for the mail. Yes there are some common structures, however >>> as of now we have kept separately considering both >>> >>> are part of different sub systems. But may be will consider this >>> input for future enhancement. >> It can be done in a form of shared definitions at least in >> include/linux/platform_data/x86/amd-mp2.h or alike ... >> > I managed to add support for the AMD SFH PCI device to i2c-amd-mp2* and > outsourced the headers to include/linux/i2c-amd-mp2.h. [1] > I also refactored the patch series (excluded the documentation) [2] to > use the PCI device now provided by i2c_amd_mp2_pci and removed some > duplicate and unncessary code. > The driver now consist of just one module (amd_sfhtp_hid). > Unfortunately I was not able to solve the problem, that I get AMD-Vi > IO_PAGE_FAULT errors when not booted with amd_iommu=off. > > [1] https://gist.githubusercontent.com/conqp/4d726f86da8a8397d6e70091a124de67/raw/f97e88a0b44d98bfa1258cb73c8afe4dce7afa87/i2c-amd-mp2.patch > [2] https://gist.githubusercontent.com/conqp/67036e690aca89d08b958971edac283d/raw/2a1ef122f9c8c8e07164b6d597962ce7bbad6d45/amd-sfhtp.patch Thanks for the patch and appreciate your efforts. At this point of time, we would like to have our first patch for SFH to be upstreamed and dont want to complicate the with two sub systems and maintainers. Surely will consider this input for future enhancement. Thanks for your understanding. Thanks Nehal
