On Mon, Mar 30, 2020 at 2:38 AM Masahiro Yamada <masahiroy@xxxxxxxxxx> wrote: > > Hi Rob, > > On Mon, Mar 30, 2020 at 4:09 PM Masahiro Yamada <masahiroy@xxxxxxxxxx> wrote: > > > > On Thu, Mar 26, 2020 at 7:06 AM Rob Herring <robh@xxxxxxxxxx> wrote: > > > > > > Setting 'additionalProperties: false' is frequently omitted, but is > > > important in order to check that there aren't extra undocumented > > > properties in a binding. > > > > > > Ideally, we'd just add this automatically and make this the default, but > > > there's some cases where it doesn't work. For example, if a common > > > schema is referenced, then properties in the common schema aren't part > > > of what's considered for 'additionalProperties'. Also, sometimes there > > > are bus specific properties such as 'spi-max-frequency' that go into > > > bus child nodes, but aren't defined in the child node's schema. > > > > > > So let's stick with the json-schema defined default and add > > > 'additionalProperties: false' where needed. This will be a continual > > > review comment and game of wack-a-mole. > > > > > > Signed-off-by: Rob Herring <robh@xxxxxxxxxx> > > > --- > > > > > > > .../devicetree/bindings/gpio/socionext,uniphier-gpio.yaml | 2 ++ > > > > > > You may have already queue this up, but just in case. > > > > Acked-by: Masahiro Yamada <yamada.masahiro@xxxxxxxxxxxxx> > > > > I take back Ack for socionext,uniphier-gpio.yaml > > > > Now "make dt_binding_check" produces a new warning. > > gpio@55000000: 'interrupt-parent' does not match any of the regexes: > 'pinctrl-[0-9]+' > > > This binding uses 'interrupt-parent' > without 'interrupts'. > > Instead, the mapping of the interrupt numbers > is specified by the vendor-specific property > socionext,interrupt-ranges > > > > I cannot add "interrupt-parent: true" because > dt-schema/meta-schemas/interrupts.yaml > has "interrupt-parent: false". > > > Is there any solution? I'd meant to just drop socionext,uniphier-gpio.yaml. Rob
